8281234: The -protected option is not always checked in keytool and jarsigner #3163
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
openjdk
bot
changed the title
|
This backport pull request has now been updated with issue from the original commit. |
| -J--add-exports -Jjava.base/sun.security.tools.keytool=ALL-UNNAMED | ||
| -J--add-exports -Jjava.base/sun.security.x509=ALL-UNNAMED | ||
| -providerClass AutoKeyStore$AutoProvider | ||
| -providerPath $test.classes |
There was a problem hiding this comment.
You changed the code below due to missing "8281175: Add a -providerPath option to jarsigner", but here, there is still "-providerPath".
There was a problem hiding this comment.
The code above calls keytool which supports the argument. jarsigner does not. For jarsigner it was added by above mentioned change.
| launcher.addVMArg(System.getProperty(jarg.substring(1))); | ||
| } else { | ||
| launcher.addVMArg(jarg); | ||
| } |
There was a problem hiding this comment.
For which property is this needed? I can't see such code upstream.
I would like to fix this issue in 17. I think it's important to get this feature rigtht.
I had to work around missing "8281175: Add a -providerPath option to jarsigner" in the test, else the patch would be clean.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3163/head:pull/3163$ git checkout pull/3163Update a local copy of the PR:
$ git checkout pull/3163$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3163/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3163View PR using the GUI difftool:
$ git pr show -t 3163Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3163.diff
Using Webrev
Link to Webrev Comment